14 Mar
2023
14 Mar
'23
10:38 p.m.
Attention is currently required from: laforge, pespin, daniel.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31866 )
Change subject: Optimize subscr_conns lookup ......................................................................
Patch Set 2:
(1 comment)
File src/osmo-bsc/bsc_sccp.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31866/comment/6cb1f1ca_4d43b782 PS2, Line 47: OSMO_ASSERT(conn_id != SCCP_CONN_ID_UNSET); while unlikely, as I understand it can still happen that all IDs are exhausted and we end up with UNSET, right? maybe reject the connection instead?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31866
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I667d3ec1dad0ab7bc0fa4799d9611f3a914d07e5
Gerrit-Change-Number: 31866
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Tue, 14 Mar 2023 11:38:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment