fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41906?usp=email )
Change subject: trxcon/fsm: handle_dch_est_req(): do not reset the scheduler ......................................................................
trxcon/fsm: handle_dch_est_req(): do not reset the scheduler
Calling l1sched_reset() results in resetting the UL SACCH cache, that may have been populated prior to sending L1CTL_DM_EST_REQ. Instead, do what the comment says - call l1sched_del_all_ts().
Change-Id: Iff03fa5b90ac1ec30b7937cea6bd09c6ececb5f6 Fixes: c6fe9c3f ("trxcon: trxcon_fsm: permit loop [P]DCH transitions") Related: 15877ba05 ("trxcon: allow populating global SACCH cache via L1CTL") Related: OS#6919 --- M src/host/trxcon/src/trxcon_fsm.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/06/41906/1
diff --git a/src/host/trxcon/src/trxcon_fsm.c b/src/host/trxcon/src/trxcon_fsm.c index 34ca21b..fa0584d 100644 --- a/src/host/trxcon/src/trxcon_fsm.c +++ b/src/host/trxcon/src/trxcon_fsm.c @@ -352,7 +352,7 @@ }
/* Remove all active timeslots */ - l1sched_reset(trxcon->sched); + l1sched_del_all_ts(trxcon->sched);
rc = l1sched_configure_ts(trxcon->sched, req->chan_nr & 0x07, config); if (rc)