25 Feb
2026
25 Feb
'26
4:57 p.m.
Attention is currently required from: Hoernchen, laforge.
pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email )
Change subject: fix --disable-log-macros ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File configure.ac:
https://gerrit.osmocom.org/c/libosmocore/+/42203/comment/f08175be_a31be9e6?u... : PS1, Line 511: if test x"$log_macros" == x"yes" The problem is not the $enableval above, which I think is fine. The problem is actually the "if" here. We should check for x"$log_macros" != x"yes", or for x"$log_macros" == x"no" here.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42203?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I809ab2f61e72428ba21061055296eb83d6d710ab
Gerrit-Change-Number: 42203
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: Hoernchen ewild@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Wed, 25 Feb 2026 15:57:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes