laforge has submitted this change. (
https://gerrit.osmocom.org/c/dahdi-linux/+/26968 )
Change subject: icE1usb: Use USB_CTRL_SET_TIMEOUT (5s) instead of hand-coded 1s
......................................................................
icE1usb: Use USB_CTRL_SET_TIMEOUT (5s) instead of hand-coded 1s
This seems to be the kernel default for CTRL request timeout,
let's use it here.
Change-Id: I7b7c1a2b13f61372e839e34a376e66c91190bdb3
---
M drivers/dahdi/icE1usb/icE1usb.c
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved; Verified
diff --git a/drivers/dahdi/icE1usb/icE1usb.c b/drivers/dahdi/icE1usb/icE1usb.c
index 7744828..13af6fc 100644
--- a/drivers/dahdi/icE1usb/icE1usb.c
+++ b/drivers/dahdi/icE1usb/icE1usb.c
@@ -209,7 +209,8 @@
rc = usb_control_msg(ieu->usb_dev, usb_sndctrlpipe(ieu->usb_dev, 0),
ICE1USB_INTF_SET_TX_CFG, USB_RT_VEND_IF,
- 0, 0, &ieu->cfg.tx, sizeof(ieu->cfg.tx), 1000);
+ 0, 0, &ieu->cfg.tx, sizeof(ieu->cfg.tx),
+ USB_CTRL_SET_TIMEOUT);
if (rc < 0)
return rc;
if (rc != sizeof(ieu->cfg.tx))
--
To view, visit
https://gerrit.osmocom.org/c/dahdi-linux/+/26968
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I7b7c1a2b13f61372e839e34a376e66c91190bdb3
Gerrit-Change-Number: 26968
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged