Attention is currently required from: dexter, fixeria, laforge.
Hello Jenkins Builder, dexter, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/40237?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Verified-1 by Jenkins Builder
Change subject: Get rid of [now] superfluous HexAdapter
......................................................................
Get rid of [now] superfluous HexAdapter
With the introduction of using osmocom.construct.{Bytes,GreedyBytes}
in Change-Id I1c8df6350c68aa408ec96ff6cd1e405ceb1a4fbb we don't have a
need for wrapping each instance of Bytes or GreedyBytes into a
HexAdapter anymore. The osmocom.construct.{Bytes,GreedyBytes} will
automatically perform the related hex-string-to-bytes conversion if
needed - and during printing we have osmocom.utils.JsonEncoder that
makes sure to convert any bytes type to a hex-string.
Change-Id: I9c77e420c314f5e74458628dc4e767eab6d97123
---
M pySim/ara_m.py
M pySim/cat.py
M pySim/cdma_ruim.py
M pySim/euicc.py
M pySim/global_platform/__init__.py
M pySim/global_platform/install_param.py
M pySim/gsm_r.py
M pySim/sms.py
M pySim/sysmocom_sja2.py
M pySim/ts_102_221.py
M pySim/ts_102_310.py
M pySim/ts_31_102.py
M pySim/ts_31_103.py
M pySim/ts_31_103_shared.py
M pySim/ts_51_011.py
M tests/unittests/test_utils.py
16 files changed, 205 insertions(+), 200 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/37/40237/2
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/40237?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I9c77e420c314f5e74458628dc4e767eab6d97123
Gerrit-Change-Number: 40237
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>