osmith has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-ci/+/27253
)
Change subject: lint: checkpatch: ignore MISSING_SPACE
......................................................................
lint: checkpatch: ignore MISSING_SPACE
Don't require breaking strings at spaces. This is not useful for strings
of hex characters, e.g.:
{ 123, "ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
"ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
"ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff"
Change-Id: Ib6be7744418530ae3ddbf373e67d1d7f25a60508
---
M lint/checkpatch/checkpatch_osmo.sh
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/53/27253/1
diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh
index 93b601b..faf0fca 100755
--- a/lint/checkpatch/checkpatch_osmo.sh
+++ b/lint/checkpatch/checkpatch_osmo.sh
@@ -64,6 +64,7 @@
# * LINE_CONTINUATIONS: false positives
# * LINE_SPACING: we don't always put a blank line after declarations
# * LONG_LINE*: should be 120 chars, but exceptions are done often so don't fail
here
+# * MISSING_SPACE: warns about breaking strings at space characters, not useful for long
strings of hex chars
# * PREFER_DEFINED_ATTRIBUTE_MACRO: macros like __packed not defined in libosmocore
# * PREFER_FALLTHROUGH: pseudo keyword macro "fallthrough" is not defined in
libosmocore
# * REPEATED_WORD: false positives in doxygen descriptions (e.g. '\param[in] data
Data passed through...')
@@ -103,6 +104,7 @@
--ignore LONG_LINE \
--ignore LONG_LINE_COMMENT \
--ignore LONG_LINE_STRING \
+ --ignore MISSING_SPACE \
--ignore PREFER_DEFINED_ATTRIBUTE_MACRO \
--ignore PREFER_FALLTHROUGH \
--ignore REPEATED_WORD \
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ci/+/27253
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ib6be7744418530ae3ddbf373e67d1d7f25a60508
Gerrit-Change-Number: 27253
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange