Attention is currently required from: laforge, osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email )
Change subject: socket: Introduce API osmo_sock_sctp_get_peer_addr_info()
......................................................................
Patch Set 3:
(3 comments)
File src/core/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/35276/comment/2dbe5821_0f929f93
PS2, Line 2660: [out]
Ah I thought one had to set out there, thanks.
https://gerrit.osmocom.org/c/libosmocore/+/35276/comment/ac9e18cc_623851fa
PS2, Line 2668: g
f
Done
https://gerrit.osmocom.org/c/libosmocore/+/35276/comment/90c3cbac_394d50c9
PS2, Line 2694: n_addrs
this might be simpler if you only count to *pinfo_cnt?
You can't do that since *pinfo_cnt is an in param containing the size of the
array, so *pinfo_cnt may be smaller than n_addrs. Hence they need to be kept separate.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35276?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3e1c84526b006baff435bbbca49dc6cf7d201cf5
Gerrit-Change-Number: 35276
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 11 Dec 2023 10:35:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment