Attention is currently required from: laforge, osmith.
View Change
3 comments:
File src/core/socket.c:
Patch Set #2, Line 2660: [out]
[in,out] (see https://www.doxygen.nl/manual/commands. […]
Ah I thought one had to set out there, thanks.
Patch Set #2, Line 2668: g
f
Done
Patch Set #2, Line 2694: n_addrs
this might be simpler if you only count to *pinfo_cnt?
You can't do that since *pinfo_cnt is an in param containing the size of the array, so *pinfo_cnt may be smaller than n_addrs. Hence they need to be kept separate.
To view, visit change 35276. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I3e1c84526b006baff435bbbca49dc6cf7d201cf5
Gerrit-Change-Number: 35276
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Comment-Date: Mon, 11 Dec 2023 10:35:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Gerrit-MessageType: comment