Attention is currently required from: fixeria, osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/34543?usp=email )
Change subject: vty: make NCC Permitted (SI2) configurable
......................................................................
Patch Set 1: -Code-Review
(1 comment)
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/34543/comment/f143f5a7_1a2e0a7a
PS1, Line 1447: no ncc-permitted
Using `no ncc-permitted` in order to permit all NCCs
looks confusing, IMO. […]
ACK, I also found it a bit confusing and I was expecting
some "all" value.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/34543?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I71bb855c35378f8f0598bc11a42bd274b7232a5e
Gerrit-Change-Number: 34543
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 27 Sep 2023 12:39:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment