Attention is currently required from: fixeria, laforge, pespin.
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35872?usp=email )
Change subject: pick up all *.vty in EXTRA_DIST ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
That rings a bell for me too.
I observe that:
- all *.vty files are present in the distro tar on https://obs.osmocom.org/package/show/osmocom:master/osmo-bsc
- but also neighbor_ident.vty is present in https://obs.osmocom.org/package/show/osmocom:master/osmo-msc even though it is missing from Makefile.am's EXTRA_DIST
That confuses me. When I do 'make dist' in osmo-msc, neighbor_ident.vty is missing from the distro tar. Aren't the packages in OBS built from 'make dist'??????
For the record, 'make dist' in osmo-bsc includes all *.vty files as expected, so the wildcard Works For Me (TM)...
I know about all those aspects of wildcards in build files, yet in practice I find that: anything without a wildcard will have us forget to add *.vty files to Makefile.am, and using the wildcard means we will never forget them again...
Let's clarify first why non-make-dist files show up in OBS.