Attention is currently required from: pespin.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31880?usp=email )
Change subject: Make NSE timing data configurable ......................................................................
Patch Set 7:
(4 comments)
File include/osmocom/bsc/bts.h:
https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/79739441_23ab5969 PS2, Line 326: #define GSM_BTS_TDEF_ID_TNS_BLOCK_NEG29 (-29)
Better leave some space in the number series so that we can later on add similar timers next to the […]
Done
File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/39ebfef1_022fa19a PS2, Line 187: struct osmo_tdef *tdefs = bts->network->T_defs;
Again, this needs to be per BTS.
Done
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/2a683e66_6e7a8c89 PS2, Line 76: static const int gprs_ns_timer_tdef_data[][2] = {
AFAICT this is only used in cfg_bts_gprs_ns_timer_cmd, so it can be moved there.
I originally put it below `gprs_ns_timer_strs` so that the index correspondence can be checked easily. I've moved it now.
https://gerrit.osmocom.org/c/osmo-bsc/+/31880/comment/5f9337fe_17162c2b PS2, Line 1627: int idx = get_string_value(gprs_ns_timer_strs, argv[0]);
so you are converting to an index here once, and in line 1637 again. This looks ptoentially wrong. […]
Not sure what you mean to say. I'm only converting a string to an index once. That same index is then used to get the corresponding data for setting the tdef for the BTS.