Attention is currently required from: jolly.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144 )
Change subject: BSSMAP_Templates: Add templates to receive CellID IE
......................................................................
Patch Set 4: Code-Review+2
(2 comments)
File library/BSSMAP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144/comment/b86717f5_fca3…
PS3, Line 371: present
There's still something wrong with this template.
[…]
We had a call with @jolly and agreed that it's better to accept MCC/MNC pair
in form of already encoded blob. This obligates the caller to call `f_enc_mcc_mnc()` when
using this template, but on the other hand allows passing `?`. Marking as resolved.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144/comment/ca30e74c_d6ad…
PS3, Line 1467: GsmMcc mcc, GsmMnc mnc
Here I suggest keeping both `mcc` and `mnc` as they
are, i.e. value parameters. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33144
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I42d52d871c8011db7e0897dfe752afeefa6d9662
Gerrit-Change-Number: 33144
Gerrit-PatchSet: 4
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Fri, 09 Jun 2023 14:04:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment