20 Dec
2024
20 Dec
'24
6:16 p.m.
Attention is currently required from: laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39168?usp=email )
Change subject: pcap-client: Add missing '_conn' in function names ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
commitlog could have a "[cosmetic]" or 'cosmetic:' declaration.
imho this is not cosmetic since it's changing symbol names, etc. I tend to use cosmetic when changing stuff like comments, whitespace, etc.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/39168?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: Ide92b28938b89ea1130d89dd0243607c861045f2
Gerrit-Change-Number: 39168
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Fri, 20 Dec 2024 17:16:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org