Jenkins Builder has posted comments on this change by kirr. ( https://gerrit.osmocom.org/c/osmocom-bb/+/40051?usp=email )
Change subject: trx_toolkit/fake_trx: Split it into fake_trx and _fake_trx modules ......................................................................
Patch Set 1:
(2 comments)
File src/target/trx_toolkit/_fake_trx.py:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/40051/comment/1b505f69_07fd4d5d?us... : PS1, Line 216: msg.burst = None # burst bits are omited 'omited' may be misspelled - perhaps 'omitted'?
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmocom-bb/+/40051/comment/28e7a449_edbf9a6e?us... : PS1, Line 218: # TODO: shoud we make these values configurable? 'shoud' may be misspelled - perhaps 'should'?