Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33770 )
Change subject: rlcmac: Introduce L1CTL-CCCH_READY.ind primitive ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Patchset:
PS1: Don't you need to modify the unit tests to send the new prim?
File include/osmocom/gprs/rlcmac/rlcmac_prim.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33770/comment/8154d56e_eedbfd4a PS1, Line 198: ccch_ready Having empty structs is a bit weird, but ok.
File src/rlcmac/gre.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33770/comment/238b3f0a_ff32d567 PS1, Line 42: struct gprs_rlcmac_entity *gre = data; Why not removing it? Does it make sense to keep it commented out?