Attention is currently required from: Timur Davydov.
Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42411?usp=email )
Change subject: transceiver: add optional WebSDR device support ......................................................................
Patch Set 7:
(11 comments)
File Transceiver52M/Transceiver.h:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/e25ffefe_ca284f1b?usp=... : PS7, Line 246: int driveReceiveRadioShortVector(std::vector<short *> &bufs, int samples, int underrun, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/4c5c69c1_e3198752?usp=... : PS7, Line 247: TIMESTAMP ts, unsigned samples_skipped); code indent should use tabs where possible
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/b2436f7c_b94e24bb?usp=... : PS7, Line 249: bool driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/99c1d1a5_96743092?usp=... : PS7, Line 258: bool driveReceiveFIFO(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/8f958c2d_2037c541?usp=... : PS7, Line 264: @brief modulation and sorting of GSM bursts from GSM core please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/eee5f498_c47038d3?usp=... : PS7, Line 265: @param chan channel number please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/7b1f5edf_ecc7c250?usp=... : PS7, Line 266: @param burstBuffer optional buffer containing burst to transmit, if not provided, will read from data socket please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/66cef063_02dee89e?usp=... : PS7, Line 267: @param burstBufferLen optional length of burst buffer, if not provided, will read from data socket please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/48db6585_446a1afa?usp=... : PS7, Line 270: bool driveTxPriorityQueue(size_t chan, char *burstBuffer = nullptr, size_t burstBufferLen = 0); please, no spaces at the start of a line
File Transceiver52M/radioInterface.h:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/f19cef97_25286164?usp=... : PS7, Line 118: int driveReceiveRadio(unsigned samples_skipped = 0); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42411/comment/18877173_de1cf5a0?usp=... : PS7, Line 137: int fillPullBuffer(std::vector<short *> &bufs, int samples, int recvunderrun, TIMESTAMP ts); please, no spaces at the start of a line