Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/36583?usp=email )
Change subject: tests/stream: Fix missing msgb_free()
......................................................................
Patch Set 1:
(1 comment)
File tests/stream/stream_test.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/36583/comment/3d2c7684_5e80345a
PS1, Line 598: return 0;
how does it get freed in the other code paths? (if
(*msgt == IPAC_MSGT_ID_RESP) and when both if and […]
Oh I thought it was actualy
forwaded with "osmo_stream_srv_send(conn, m);", but now that you mention it,
another msgb is actually allocated, so the "msg" is leaked.
Good catch!
I'll change it.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/36583?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7e7579175aa6a7c1c22eb3bc147a67f6f62ad6bc
Gerrit-Change-Number: 36583
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Apr 2024 08:45:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment