Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/28099 )
Change subject: Add new Manuall "OsmoBSC CBSP Protocol Specification"
......................................................................
Patch Set 1:
(4 comments)
File doc/manuals/Makefile.am:
https://gerrit.osmocom.org/c/osmo-bsc/+/28099/comment/2a95bc18_4b129c60
PS1, Line 22: #
What does '#' mean here?
File doc/manuals/cbsp/messages.adoc:
https://gerrit.osmocom.org/c/osmo-bsc/+/28099/comment/58b0e2d4_3aefc2bd
PS1, Line 15: | TS 48.049 § | This document § | Message | <-/-> | Received/Sent by
OsmoBSC
what is the "<-/->" column indicating?
it's not clear to me.
Apparently it's indicating direction '<-'
or '->'. But given that the next column basically has the same meaning, this
one looks redundant.
https://gerrit.osmocom.org/c/osmo-bsc/+/28099/comment/ae4f9bc6_4c4388d0
PS1, Line 59: The RESET FAILURE message hence only occurs if the CBC were to identify
So you mean here osmo-bsc never sends RESET FAILURE,
but that a CBC implementation connected the oth […]
Ack, I also find this confusing.
Most likely, existing/non-existent cell is the key difference here. To make it easier to
understand I would start the second paragraph with something like "For a non-existent
cell though, ...".
File doc/manuals/cbsp/procedures.adoc:
https://gerrit.osmocom.org/c/osmo-bsc/+/28099/comment/1f80d9fc_c7049766
PS1, Line 34: of OsmoBTS and OsmoPCU):
maybe describe which versions, as in > 1.7.0 or
whatever.
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/28099
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2e18e167281fac3abaf380089ff883738ebaa0a0
Gerrit-Change-Number: 28099
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 13 May 2022 10:38:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment