Attention is currently required from: osmith.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/36071?usp=email )
Change subject: gtp/gsn: gtp_new: replace calloc with talloc_zero ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1: introducing this would break any hypothetical users of libgtp that use multiple threads, as we're introducing a single talloc context.
Going for __thread would have a per-thread talloc context.
Alternatively, you could simply add a new function where the user can pass in explicitly a talloc context. Then it's the users choice whether to use the legacy API (uses libgtp-internal talloc context like your patch) or pass in a (potentially thread specific) talloc context when creating the gsn.