Attention is currently required from: pespin, fixeria, dexter.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/29924
)
Change subject: Move UL allocation&assign functions to gprs_ms.c
......................................................................
Patch Set 3: Code-Review+1
(2 comments)
File src/gprs_ms.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/29924/comment/e3408b1c_fddd6413
PS3, Line 1091:
I changed it to have it all the functions looks
similar. […]
Ack
File src/tbf_fsm.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/29924/comment/84d172d5_c376a078
PS3, Line 105: ul_tbf_contention_resolution_start(ul_tbf);
It's not really a change in in functionality,
I'm just moving the function call here inside the FSM […]
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/29924
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I256aeede2a2678c9738539fb6ec4db9766fa85e4
Gerrit-Change-Number: 29924
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 03 Nov 2022 10:33:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment