Attention is currently required from: matanp.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/32425
)
Change subject: ctrl: Add cell reselection offset control
......................................................................
Patch Set 1:
(3 comments)
File src/osmo-bsc/bts_ctrl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/9086eba3_fda01b39
PS1, Line 721: cmd->reply = talloc_asprintf(cmd, "%u",
bts->si_common.cell_ro_sel_par.cell_resel_off*2);
space between " * "
https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/891acfd6_c9923118
PS1, Line 723: cmd->reply = "OOM.";
I think we never put a dot in replies?
https://gerrit.osmocom.org/c/osmo-bsc/+/32425/comment/13cba5bf_1d004edd
PS1, Line 734: bts->si_common.cell_ro_sel_par.cell_resel_off = atoi(cmd->value)/2;
space between " / "
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/32425
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I159bbe14e71dbf1e1add60b57b0b2e03d3146682
Gerrit-Change-Number: 32425
Gerrit-PatchSet: 1
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: matanp <matan1008(a)gmail.com>
Gerrit-Comment-Date: Tue, 25 Apr 2023 09:49:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment