Attention is currently required from: fixeria, laforge, neels.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/libosmo-pfcp/+/39459?usp=email )
Change subject: Port pfcp socket to osmo_iofd
......................................................................
Patch Set 2:
(2 comments)
File src/libosmo-pfcp/pfcp_endpoint.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/39459/comment/0af4a2a7_ab658eb1… :
PS1, Line 492: struct osmo_io_ops ioops
`static const`?
Done
https://gerrit.osmocom.org/c/libosmo-pfcp/+/39459/comment/7005acf6_393a3e9d… :
PS1, Line 517: if (rc < 0)
You're checking `rc < 0` twice now, is this
second check still needed?
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-pfcp/+/39459?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: If85888b6857899e0aca1fdd1d806c53476b4d239
Gerrit-Change-Number: 39459
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Feb 2025 09:45:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>