Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-upf/+/27217
)
Change subject: libosmo-tlv: add versatile TLV de- and encoder
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
As I stated previously here and privately in previous versions, I'm not really liking
the approach of having function pointers which have to be implemented by each protocol in
order to, for instance, write a u8 or u32 TLV.
That being said, if you like this approach then so be it. I'm not opossing to this
being merged this way if others are also fine with it.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-upf/+/27217
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Ib0fd00d9f288ffe13b7e67701f3e47073587404a
Gerrit-Change-Number: 27217
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Mar 2022 16:09:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment