Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/simtrace2/+/26985 )
Change subject: contrib/simtrace.lua: Add Flag bits + Data to COL_INFO
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File contrib/simtrace.lua:
https://gerrit.osmocom.org/c/simtrace2/+/26985/comment/a3563396_f39258c6
PS1, Line 93: if is_pbrx().value == 1 then
Using ternary operator may improve readability here:
[…]
Done
--
To view, visit
https://gerrit.osmocom.org/c/simtrace2/+/26985
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I0aa3d68172022907fbe8371aaca6538df0649dfe
Gerrit-Change-Number: 26985
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Feb 2022 14:02:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment