4 Mar
2023
4 Mar
'23
3:36 a.m.
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31657 )
Change subject: modem: add test VTY command for sending raw LLC PDUs ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/host/layer23/src/modem/vty.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/31657/comment/0b2217a7_e793eeab PS1, Line 90: "test MS_NAME llc unitdata-req <0x00-0xffffffff> SAPI HEXSTRING", isn't the TLLI initially generated automatically by the MS? maybe simply do so and assign it to the "ms" object instead of the user having to pass it?
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31657
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I14f58e715d77a1b1cb40fdd3ddd09084360f2274
Gerrit-Change-Number: 31657
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Fri, 03 Mar 2023 16:36:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment