Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854 )
Change subject: pgw: Add TC_gy_charging_cc_time
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
Patchset:
PS2:
ping
Huh, the two comments I left were not
marked as Resolved, so I thought they're not addressed.
File pgw/PGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854/comment/0b81d6cd_5ec5…
PS1, Line 688: /* create a session, then execute a ping command on the user plane */
This test is not only about creating session and
running ping, right? This comment needs to be clari […]
Done
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854/comment/0000a7f1_f969…
PS1, Line 715: control {
Is it intentional that you don't add
TC_gy_charging_cc_time to the control section?
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27854
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie4e567f62bbbdba276e6b3221111c8d9f82cde14
Gerrit-Change-Number: 27854
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Apr 2022 09:15:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment