10 Nov
2025
10 Nov
'25
5:51 p.m.
Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email )
Change subject: Add test for tcap decoding/encoding ......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Agreeing with Pau. Unit tests for TCAP codec should be in libosmo-asn1-tcap.git. […]
It ensures the library works correctly. We had issues in the past with linking again asn1 libraries.
I don't oppose against adding unit tests to asn1-tcap, but keeping this simple test here.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41308?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I8a0dbfaaa7182a5a72b279908be09e3adab254a2
Gerrit-Change-Number: 41308
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-CC: daniel dwillmann@sysmocom.de
Gerrit-CC: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 10 Nov 2025 16:51:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de