Attention is currently required from: jolly, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email )
Change subject: bring twjit into libosmo-netif ......................................................................
Patch Set 5:
(2 comments)
File include/osmocom/netif/twjit.h:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/147d1af4_a1b48df5... : PS2, Line 137: bool osmo_twjit_got_any_input(struct osmo_twjit *twjit);
I haven't forgotten about this API rename idea, but I haven't changed it in patchset 3 - too many ot […]
I have warmed up to your idea of renaming this API, and I would like to include the same rename in my `twrtp-native` (director's cut) version so this part remains consistent. Please indicate whether you prefer `osmo_twjit_rr_info_is_valid()` or slightly shorter `osmo_twjit_rr_info_valid()`.
File src/twjit.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/9785e1a6_e924e287... : PS2, Line 504: rtph = osmo_rtp_get_hdr(msg);
@falcon@freecalypso.org yes several people I know, not only you, (eg. me and @vyanitskiy@sysmocom. […]
@pespin@sysmocom.de: nice to hear about your interest in seeing twrtp merged and become a replacement for ortp. I plan to proceed as follows:
1. I am putting together a "director's cut" version of twrtp that is no longer a prototype (not `twrtp-proto`), that will be used long-term by ThemWi network elements. This ThemWi-native version of twrtp (controlled by me only) will reside in ThemWi area of Osmocom Gitea, planned name `twrtp-native`.
2. The manual in troff-to-PDF format, hosted on freecalypso.org, will describe `twrtp-native` version.
3. In the next revision of the present patchset, the version submitted for inclusion into `libosmo-netif` will officially become a "derivative work based on Themyscira Wireless library", and will be able to contain features requested by Osmocom that can never go into ThemWi-official version.
4. I will add a third patch to this series (revive the one dealing with documentation), adding a local version of the manual to `libosmo-netif/doc`, one that can change in sync with the code.
5. Preparation of merge-candidate patches to OsmoBTS will begin when and if `libosmo-netif` patches are merged.
OsmoBTS patch plans: you can look at my `falconia/twrtp*` branches in `osmo-bts` repo (3 branch versions so far) to see how I plan to address this one, if and when twrtp joins `libosmo-netif`. There I create an OsmoBTS-internal abstraction layer that can use either ortp or twrtp, selectable by vty config, along with a provision to make ortp compile-optional. twrtp then becomes mandatory only if the user chose to compile with ortp excluded. Or are you instead thinking about dropping ortp completely? The latter I could never imagine in my wildest dreams, but if you really do want to go there, let's revisit it after we get twrtp merged into Osmocom libs.