Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-pcap/+/39367?usp=email )
Change subject: server: Implement non-blocking write to pcap file with osmo_io
......................................................................
Patch Set 3: Code-Review+1
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcap/+/39367/comment/b12465f7_9dd075eb?us… :
PS3, Line 12: Change-Id: I098a9455a2a4cc626444e6fc13aa88c4cc9694f0
Depends: libosmo-netif I80a1c4b227629e3ca0c8c587a103db6057322cb4
File src/osmo_pcap_wr_file.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39367/comment/ebeaef5d_cc4d8b96?us… :
PS2, Line 47: werf
wrf?
Done
File src/osmo_server_core.c:
https://gerrit.osmocom.org/c/osmo-pcap/+/39367/comment/592f643d_5d9c30ae?us… :
PS2, Line 262: lossing
losing
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcap/+/39367?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Gerrit-Change-Id: I098a9455a2a4cc626444e6fc13aa88c4cc9694f0
Gerrit-Change-Number: 39367
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 20 Jan 2025 11:47:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>