Jenkins Builder has posted comments on this change by keith. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40917?usp=email )
Change subject: Add functions to set LAC/CI on a BTS and update hashtables. ......................................................................
Patch Set 3:
(8 comments)
File src/osmo-bsc/bts.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/47a2e3dd_a3ad6470?usp=... : PS3, Line 761: int gsm_bts_set_lac(struct gsm_bts *bts, int lac) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/d7861df3_e851cc4a?usp=... : PS3, Line 772: int gsm_bts_set_ci(struct gsm_bts *bts, int ci) { open brace '{' following function definitions go on the next line
File src/osmo-bsc/bts_ctrl.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/bf806338_139b019c?usp=... : PS3, Line 247: static int get_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/cd392fbd_b63152b9?usp=... : PS3, Line 257: static int set_bts_lac(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/25a70f92_dfcc7333?usp=... : PS3, Line 266: static int verify_bts_lac(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/4cc3e52c_3f7e4f6e?usp=... : PS3, Line 280: static int get_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/6f858d44_448561b9?usp=... : PS3, Line 290: static int set_bts_ci(struct ctrl_cmd *cmd, void *data) { open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/40917/comment/4bc5d20e_dd7138f7?usp=... : PS3, Line 299: static int verify_bts_ci(struct ctrl_cmd *cmd, const char *value, void *data) { open brace '{' following function definitions go on the next line