Attention is currently required from: laforge.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31577
)
Change subject: abis_rsl: guard against over long IMMEDIATE ASSIGNMENT Messages
......................................................................
Patch Set 4:
(1 comment)
File src/osmo-bsc/abis_rsl.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31577/comment/91c70e06_e0877102
PS3, Line 948: val
we have to be a bit carefult with assert's to
avoid ending up in the sukchan-style of software devel […]
I ran into this due to a
programming mistake, but yes, its probably wiser to return NULL.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/31577
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I9417b35fb8c0517f2555e17059bf8ac60fa59791
Gerrit-Change-Number: 31577
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 01 Mar 2023 12:50:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment