Attention is currently required from: falconia.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/33471 )
Change subject: ECU in UL path: move it from trx model to l1sap
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/33471/comment/ed77ca9d_61ab07ca
PS1, Line 1852: gsm_fn2gsmtime
`l1sap_tch_ind()` does this calculation before calling this new helper function, so maybe
accept a `const struct gsm_time` pointer instead of just `uint32_t fn`? FYI, the `struct
gsm_time` does contain the `fn` field too. Not really critical, but we can save some CPU
cycles, especially given that this calculation is needed for `DEBUG` logging only.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/33471
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iac577975c9ab50cb8ebbc035c661c1880e7cecec
Gerrit-Change-Number: 33471
Gerrit-PatchSet: 1
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: falconia <falcon(a)freecalypso.org>
Gerrit-Comment-Date: Tue, 27 Jun 2023 09:22:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment