Attention is currently required from: neels.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178 )
Change subject: cfg: add 'hnbgw' / 'plmn MCC MNC'
......................................................................
Patch Set 5:
(1 comment)
File src/osmo-hnbgw/hnbgw_l3.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178/comment/8fa81c9d_50f62987
PS3, Line 281: osmo_plmn_from_bcd(ies->lai.pLMNidentity.buf, &local_plmn);
The two RESET related patches after this patch have
been tweaked in the meantime: osmo-hnbgw will ou […]
so, even if the behavior
changes are minimal based on whether the PLMN is configured or not, and given you are
already thinking on rejecting message indicating a mismatching local PLMN, don't you
think it makes sense to log some message informing the user that as of nowadays he should
be configuring the PLMN in the config file? (so that he doesn't run into problems
later, preparing him)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/33178
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: If404c3859acdfba274c719c7cb7d16f97d831a2a
Gerrit-Change-Number: 33178
Gerrit-PatchSet: 5
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 13 Jun 2023 09:10:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment