Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39714?usp=email )
Change subject: mgw: Early reject CRCX with X-Osmux if disabled by config ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/libosmo-mgcp/mgcp_protocol.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/39714/comment/0fc77427_4fc9e2e0?usp=... : PS1, Line 898: rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX));
Yeah I even see it being used differently in line 984, the actual meaning of this counter is basical […]
IMHO it still makes more sense to move it to the `/* Reject non-osmux if required by config */` case then... but probably not worth blocking the patch over this. LGTM otherwise.