Attention is currently required from: pespin.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/libosmo-mgcp/mgcp_protocol.c:

  • Patch Set #1, Line 898: rate_ctr_inc(rate_ctr_group_get_ctr(rate_ctrs, MGCP_CRCX_FAIL_NO_OSMUX));

    Yeah I even see it being used differently in line 984, the actual meaning of this counter is basical […]

    IMHO it still makes more sense to move it to the `/* Reject non-osmux if required by config */` case then... but probably not worth blocking the patch over this. LGTM otherwise.

To view, visit change 39714. To unsubscribe, or for help writing mail filters, visit settings.