Attention is currently required from: arehbein, daniel, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email )
Change subject: xua + ipa: Add support for I/O in OSMO_IO mode
......................................................................
Patch Set 8:
(1 comment)
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/2c591cf5_3209cafa
PS8, Line 657: osmo_stream_cli_set_segmentation_cb(asp->client, xua_segmentation_cb);
Can we call this callback function "tcp_xua_segmentation_cb"? (prepend"tcp_"). […]
There is nothing TCP specific about this callback. In theory, it can be used with any other transport protocol which does not preserve the message boundaries. So IMO, the proposed naming is fine.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I7d02037990f4af405839309510dc6c04e36c3369
Gerrit-Change-Number: 35070
Gerrit-PatchSet: 8
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein
arehbein@sysmocom.de
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: arehbein
arehbein@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Tue, 05 Mar 2024 18:50:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment
