14 Mar
2023
14 Mar
'23
7:32 a.m.
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/31775 )
Change subject: {utils,tests}/Makefile.am: reorder libraries in LDADD ......................................................................
Patch Set 2:
(1 comment)
File tests/Makefile.am:
https://gerrit.osmocom.org/c/libosmo-netif/+/31775/comment/a990acdc_a6076f1c PS1, Line 6: $(LIBOSMOCORE_LIBS) \
these two should be swapped so that GSM is before CORE, to have proper dependency chain.
The ordering of external libraries is not really that important. What really matters is that the repository-local libraries are listed first.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/31775
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ia639b1c5460ad9391d2c311b4978ca9374789f7a
Gerrit-Change-Number: 31775
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Mon, 13 Mar 2023 20:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment