Attention is currently required from: laforge, pespin, fixeria.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/30639
)
Change subject: tests/TbfTest: reproduce buggy corner case: MS with TBFs on 2 TRXs
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/30639/comment/343e3abc_25ed5d0e
PS2, Line 10: hald
half
Patchset:
PS2:
very readable test case, nice
File tests/tbf/TbfTest.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/30639/comment/ef1d97c0_b125593a
PS2, Line 2481: /* Here we assert DL-TBF is currently moved to the new MS, which is
wrong! */
maybe put a FIXME here?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/30639
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ic16b5e96debf91e72684833cd64253687857f3aa
Gerrit-Change-Number: 30639
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 19 Dec 2022 11:29:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment