11 Mar
2026
11 Mar
'26
10:10 p.m.
Attention is currently required from: Hoernchen, laforge, tnt.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email )
Change subject: transceiver: add optional Laurent burst LUT modulation (int16) ......................................................................
Patch Set 6:
(1 comment)
File Transceiver52M/sigProcLib.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42248/comment/25330fc6_690c8228?usp=... : PS5, Line 706: unsigned modulateBits(uint8_t *bits, unsigned bitlen, int16_t *outbuf)
a read-only input paramter "bits" should be marked as "const"
Good catch — I've marked `bits` as const.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42248?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I1715c2d33dc55fe1c7be5c6e7259d378ea5e80b2
Gerrit-Change-Number: 42248
Gerrit-PatchSet: 6
Gerrit-Owner: Timur Davydov dtv.comp@gmail.com
Gerrit-Reviewer: Hoernchen ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: tnt tnt@246tNt.com
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: Hoernchen ewild@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: tnt tnt@246tNt.com
Gerrit-Comment-Date: Wed, 11 Mar 2026 11:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge laforge@osmocom.org