[L] Change in osmo-asf4-dfu[master]: add fw update crcstub

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email ) Change subject: add fw update crcstub ...................................................................... Patch Set 5: (9 comments) File crc_code.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/ff340844_b7fe43d… : PS5, Line 18: for (uint32_t i = 0; i < length; i++) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/46e4804a_1e9ba11… : PS5, Line 20: for (uint8_t j = 0; j < 8; j++) { suspect code indent for conditional statements (4, 6) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/ac95337b_3ee43f0… : PS5, Line 45: if (calculated_crc != expected_crc) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/85a5e7c0_d460d96… : PS5, Line 61: while (1) suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/063505c2_3138e5b… : PS5, Line 74: if (argc != 4) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/1a40183c_3876a99… : PS5, Line 86: if (!f) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/f5ef2d54_2fa6082… : PS5, Line 92: if (fseek(f, (long)start_offset, SEEK_SET) != 0) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/90dab0dd_305d0f7… : PS5, Line 99: if (!buf) { suspect code indent for conditional statements (2, 4) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21281): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437/comment/7d6613cb_3ba918f… : PS5, Line 108: if (read_bytes != length) { suspect code indent for conditional statements (2, 4) -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39437?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I39eae7aaafd5531db6ce48837c9499432caadbed Gerrit-Change-Number: 39437 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: Hoernchen &lt;ewild(a)sysmocom.de&gt; Gerrit-Comment-Date: Wed, 29 Jan 2025 19:15:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No