Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/32567 )
Change subject: layer23: modem: Delay GPRS attach at startup until modem is ready ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File src/host/layer23/include/osmocom/bb/modem/modem.h:
https://gerrit.osmocom.org/c/osmocom-bb/+/32567/comment/821942a9_eb7ee836 PS1, Line 12: }; what's the rationale behind not using a full osmo_fsm?
File src/host/layer23/src/modem/app_modem.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32567/comment/1a22237b_074e3276 PS1, Line 83: LOGP(DRLCMAC, LOGL_INFO, "Delaying GPRS attach, waiting for:%s%s%s%s%s%s\n", How about moving this log message into modem_gprs_attach_if_needed()? From the function names this would make more sense IMHO. Not critical.