Attention is currently required from: pespin.

Patch set 1:Code-Review +1

View Change

2 comments:

• File src/host/layer23/include/osmocom/bb/modem/modem.h:

  • Patch Set #1, Line 12: };

    what's the rationale behind not using a full osmo_fsm?

• File src/host/layer23/src/modem/app_modem.c:

  • Patch Set #1, Line 83: LOGP(DRLCMAC, LOGL_INFO, "Delaying GPRS attach, waiting for:%s%s%s%s%s%s\n",

    How about moving this log message into modem_gprs_attach_if_needed()? From the function names this would make more sense IMHO. Not critical.

To view, visit change 32567. To unsubscribe, or for help writing mail filters, visit settings.