Attention is currently required from: laforge.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16355 )
Change subject: osmo_fsm: Ensure all state and event names are valid identifiers
......................................................................
Patch Set 7:
(1 comment)
File src/fsm.c:
https://gerrit.osmocom.org/c/libosmocore/+/16355/comment/7b3eb13e_158754cd
PS7, Line 296: "state name '%s'\n", states[i].name);
I think we should rather make sure that our logging subsystem does something useful (and not assert) […]
Yes, lets do that before we eliminate the problematic state and event names. I have seen that my patch for the IuUP FSM has been merged, so XXXX.ind -> XXXX-req will become the norm.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/16355
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If98587eff3c48a66ed2e5cc1f01a12accab5a3e7
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 7
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: dexter
pmaier@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Comment-Date: Thu, 20 Jan 2022 12:17:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: dexter
pmaier@sysmocom.de
Gerrit-MessageType: comment