Attention is currently required from: fixeria, laforge, osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42326?usp=email )
Change subject: 5gc: Introduce TC_handover_inter_ngran_n2 ......................................................................
Patch Set 1:
(4 comments)
File 5gc/C5G_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42326/comment/263949ab_69cb8... : PS1, Line 714: COORD.receive(Handover_n2_Pars:?) -> value ho_n2_pars;
is this already guarded by a timer, or could it hang forever here?
we have a T_guard.
File 5gc/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42326/comment/6f29c2cd_9b12b... : PS1, Line 979: var NGAP_PDU rx_pdu;
unused
Acknowledged
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42326/comment/02ca0de4_ee91a... : PS1, Line 1056: rx_pdu
set but not used?
I really see no issue with that, it's there to be used if in the future we want to do some extra check, store some extra state, etc.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42326/comment/c27c9de0_9a066... : PS1, Line 1067: var NGAP_PDU rx_pdu;
unused
Acknowledged