18 Dec
2025
18 Dec
'25
10:22 p.m.
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41616?usp=email )
Change subject: sctp_proxy: use lists:filter/2 in sctp_send_pending/2 ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/sctp_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41616/comment/6f703c84_85dbf... : PS1, Line 307: lists:reverse(Pending)),
Yes, it's a normal practice in Erlang: you prepend items to a list and then do the reverse. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41616?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ic666fd77bc6d04341f3c57140dea5d4a5e616e80
Gerrit-Change-Number: 41616
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 18 Dec 2025 21:22:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de