Attention is currently required from: fixeria, pespin.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/31080 )
Change subject: SI: add missing header
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/01bd2acb_f0fdc14a
PS1, Line 12: Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
Fixes: 600d4eeab71665c0aec0a11a226d231f109534ca
Done
File include/osmocom/gsm/gsm48.h:
https://gerrit.osmocom.org/c/libosmocore/+/31080/comment/4b885ba5_421867fb
PS1, Line 38: const char *gsm48_rr_msg_type_short_name(uint8_t msgtype);
Ack, I also find the current naming confusing. […]
It's never too late to rename smth - we have API versioning in place.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/31080
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia7530e9c8a21f6f99f3aac7baea5cbb38763c4f3
Gerrit-Change-Number: 31080
Gerrit-PatchSet: 1
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Jan 2023 17:19:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment