Attention is currently required from: Hoernchen.
laforge has posted comments on this change by Hoernchen. (
https://gerrit.osmocom.org/c/pysim/+/40467?usp=email )
Change subject: smdpp: validate eid
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File osmo-smdpp.py:
https://gerrit.osmocom.org/c/pysim/+/40467/comment/8ee3f68c_cb5173a0?usp=em… :
PS1, Line 76: Returns 'O' for old variant
note that all of the existing code covers SGP.22 v2.x and hence only supports
"O". All the other variants with intermediate certs are SGP.22 v3.x which is
not yet supported in osmo-smdpp and not really used much in practice in general.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/40467?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ice704548cb62f14943927b5295007db13c807031
Gerrit-Change-Number: 40467
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 13 Jun 2025 20:24:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes