Attention is currently required from: laforge.
Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1d/+/30023 )
Change subject: doxygen API documentation for libosmo-e1d
......................................................................
Patch Set 2:
(8 comments)
File Doxyfile.in:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-774):
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/18b256ca_c76ef062
PS2, Line 834: # It is adviced to generate a default header using "doxygen -w html
'adviced' may be misspelled - perhaps 'advised'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-774):
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/bb837c2d_c9dadc17
PS2, Line 1488: # TAGFILES =
trailing whitespace
File include/osmocom/e1d/proto.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-774):
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/d3a830be_7a519c7c
PS2, Line 42: * filter: intf (required), line (optional); * in: n/a; out: array of
osmo_e1dp_line_info */
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-774):
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/1d0c84b9_a5b0a351
PS2, Line 112: uint16_t magic; /*< magic value (E1DP_MAGIC) */
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-774):
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/b774e525_8fc05cd5
PS2, Line 113: uint16_t len; /*< length of message (octets) */
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-774):
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/18caefc1_59d38c3a
PS2, Line 117: uint8_t line; /*< E1 line number (or E1DP_INVALID) */
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-774):
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/b7705769_ac17b00b
PS2, Line 118: uint8_t ts; /*< timeslot number (or E1DP_INVALID) */
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-774):
https://gerrit.osmocom.org/c/osmo-e1d/+/30023/comment/d672cb93_bc460e7a
PS2, Line 124: uint8_t n_lines; /*< number of E1 lines within this interface */
please, no space before tabs
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1d/+/30023
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ib4a97045bca276fbd3892f801898a436de7dc39b
Gerrit-Change-Number: 30023
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Sat, 05 Nov 2022 21:34:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment