Attention is currently required from: daniel.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email )
Change subject: tests: Test gsmtap logging if write queue fills up ......................................................................
Patch Set 2: Code-Review-1
(4 comments)
File tests/Makefile.am:
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/b0f29678_b196770f PS2, Line 18: logging/logging_test_gsmtap This file needs to be updated properly:
* define `logging_test_gsmtap_SOURCES`, * add `logging_test_gsmtap.err` to `EXTRA_DIST`.
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/742cd617_f1dc078e PS2, Line 566: logging/logging_test add the respective statement for `logging_test_gsmtap` here
File tests/logging/logging_test_gsmtap.err:
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/207ec47b_9dddbd44 PS2, Line 108: 0x611000000328 this is non-deterministic output, we should not match it
File tests/testsuite.at:
https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/cc41c509_d39525a8 PS2, Line 206: logging_test_gsmtap.ok no such file?