11 Jul
2023
11 Jul
'23
3:15 p.m.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33678
)
Change subject: configure: ipa utils: add default=yes to arg help
......................................................................
Patch Set 1:
(1 comment)
File configure.ac:
https://gerrit.osmocom.org/c/osmo-bsc/+/33678/comment/1fe50240_63933987
PS1, Line 40: [
Don't we need to escape square brackets? […]
It is written like that a few times in this configure.ac already, and it works as
expected (configure --help output, tab completion). I'm not sure why it would be
escaped like that in other projects, maybe there is a good reason for it... but it seems
to work fine here.
```
$ grep default= configure.ac
AC_ARG_ENABLE([ipaccess-utils], [AS_HELP_STRING([--enable-ipaccess-utils], [Build ipaccess
utils: abisip-find, ipaccess-config, ... [default=yes]])],
AC_ARG_ENABLE([meas-udp2db], [AS_HELP_STRING([--enable-meas-udp2db], [Build
osmo-meas-udp2db: listen to meas_feed on UDP and write it to an sqlite3 database
[default=no]])],
AC_ARG_ENABLE([meas-pcap2db], [AS_HELP_STRING([--enable-meas-pcap2db], [Build
osmo-meas-pcap2db: read PCAP file with meas_feed data and write it to an sqlite3 database
[default=no]])],
AC_ARG_ENABLE([meas-vis], [AS_HELP_STRING([--enable-meas-vis], [Build meas_vis:
curses-visualization of measurements [default=no]])],
[enable code coverage support [default=no]]),
[Include the VTY/CTRL tests in make check [default=no]]),
[Generate manual PDFs [default=no]],
```
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33678
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ie8c22f5103857b317add5f7d9d9f951665a6103a
Gerrit-Change-Number: 33678
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Jul 2023 13:15:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment